Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): bump simple-icons from 4.25.0 to 5.0.0 #6580

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps simple-icons from 4.25.0 to 5.0.0.

Release notes

Sourced from simple-icons's releases.

Release 7 new icons and 3 updated icons and 37 removed icons

Miscellanous

  • Add a DISCLAIMER.md (#4912)

NPM Package

  • Removed possibility to simpleIcons.get an icon by the brand name (#4920)
  • You should now start using simpleIcons.Get instead of simpleIcons.get (#5777)

New Icons

  • GoDaddy (#5773)
  • Microsoft Bing (#4744), previously "Bing"
  • Replit (#5730), previously "repl.it"
  • smash.gg (#5728)
  • TietoEVRY (#5685), previously "EVRY"
  • Web3.js (#5682)
  • WEBTOON (#5381), previously "LINE WEBTOON"

Updated Icons

Updated Slugs

  • .NET (#5611), from "dot-net" to "dotnet"
  • A-Frame (#5611), from "a-frame" to "aframe"
  • About.me (#5611), from "about-dot-me" to "aboutdotme"
  • Alibaba.com (#5611), from "alibaba-dot-com" to "aboutdotme'
  • AT&T (#5611), from "at-and-t" to "atandt"
  • Audio-Technica (#5611), from "audio-technica" to "audiotechnica"
  • B&R Automation (#5611), "b-and-rautomation" to "bandrautomation"
  • Battle.net (#5611), from "battle-dot-net" to "battledotnet"
  • Blockchain.com (#5611), from "blockchain-dot-com" to "blockchaindotcom"
  • Chart.js (#5611), from "chart-dot-js" to "chartdotjs"
  • Co-op (#5611), from "co-op" to "coop"
  • Conda-Forge (#5611), from "conda-forge" to "condaforge"
  • Counter-Strike (#5611), from "counter-srike" to "counterstrike"
  • D-Wave Systems (#5611), from "d-wavesystems" to "dwavesystems"
  • D3.js (#5611), from "d3-dot-js" to "d3dotjs"
  • dev.to (#5611), from "dev-dot-to" to "devdotto"
  • diagrams.net (#5611), from "diagrams-dot-net" to "diagramsdotnet"
  • Digi-Key Electronics (#5611), from "digi-eyelectronics" to "digikeyelectronics"
  • Draugiem.lv (#5611), from "draugiem-dot-lv" to "draugiumdotlv"
  • Eclipse Vert.x (#5611), from "eclipsevert-dot-x" to "eclipsevertdotx"
  • Ember.js (#5611), from "ember-dot-js" to "emberdotjs"
  • F-Droid (#5611), from "f-droid" to "fdroid"

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [simple-icons](https://github.com/simple-icons/simple-icons) from 4.25.0 to 5.0.0.
- [Release notes](https://github.com/simple-icons/simple-icons/releases)
- [Commits](simple-icons/simple-icons@4.25.0...5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the dependencies Related to dependency updates label Jun 4, 2021
@calebcartwright calebcartwright added the needs-discussion A consensus is needed to move forward label Jun 5, 2021
@calebcartwright
Copy link
Member

There's a lot going on with this one.

The first big one is that Simple Icons no longer permit/utilize hyphens within the icon file and slug names which is the source of a number of breaking changes (detailed/copied from their release notes in a new issue I created (#6590) for us to be able to pin and convey to our users after the update.

The second change is a movement away from the ability to use titles (as opposed to slugs) within the package, which has modified the package exports. This second change is the source of our test failures, and would increase the number of breaking slugs due to the way we've historically loaded/mapped slugs.

I'm not terribly familiar with the simple-icons package and the nature of the exported code being dynamically generated doesn't make for the easiest grok so please let me know if I'm off on any of this.

This appears with icons that have spaces within the title (e.g. Linux Foundation). With our current icon handling and simple-icons <=4.x both linux%20fuondation and linux-foundation are supported, e.g.

https://img.shields.io/badge/foo-bar-blue?logo=linux-foundation

https://img.shields.io/badge/foo-bar-blue?logo=linux%20foundation

interestingly, the actual slug (linuxfoundation) doesn't work

https://img.shields.io/badge/foo-bar-blue?logo=linuxfoundation

With our current icon handling and the upgraded v5 of the package this has been inverted, and now only the actual slug will work, while our currently supported slugs will break

https://shields-staging-pr-6580.herokuapp.com/badge/foo-bar-blue?logo=linux-foundation

https://shields-staging-pr-6580.herokuapp.com/badge/foo-bar-blue?logo=linux%20foundation

https://shields-staging-pr-6580.herokuapp.com/badge/foo-bar-blue?logo=linuxfoundation

I see two possible paths forward, curious what others thoughts are (both on these and any other options)

  1. Adopt the upstream paradigm shift and only support using the slugs directly. Can generate a list of impacted slugs and include them in our notice about breaking logo changes (🚀 Simple Icons 5 #6590) and also update our docs to convey to users how they can determine the simple icons slug (which is available both on the simple icons website and in the slugs.md file in their repository)
  2. Extend our icon loading logic to account for the export modifications to support all three icon references to maintain backwards compatibility (direct by current title, direct by current slug, coerced titles with spaces)

@calebcartwright
Copy link
Member

An initial pass at an implementation for option 2 provided in #6591

@dependabot-preview
Copy link
Contributor Author

Superseded by #6603.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/simple-icons-5.0.0 branch June 11, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates needs-discussion A consensus is needed to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants