remove erroneous clearRequestCache call, run [DynamicJson] #6067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
changed the title
|
|
down to some ~25 or so service test failures, which seems to be driven by some of the usual suspects (David, LibrariesIo, etc.) so compared to the 1,915 failing on master currently I think this resolves the issue
|
calebcartwright
changed the title
calebcartwright
changed the title
paulmelnikow
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This popped up in #6054 and is a follow up to #6037 which removed the in memory cache, but missed this one.
Also observable in the daily tests, where we've had 1915 out of 1926 of the service tests failing consistently for several days now. Just making note of it here to draw attention to the point I'd made in #5966 (comment)