[Wordpress] Plugin & Theme required php #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed existing testing to conform to new api options and schema. Also added testing for the new badge
Changed the Theme Not Set test to a mock as unable to find a live example (previously used 'generatepress' however this now has the data). Also split out query selector fields to allow updating in one place for themes and plugins
|
chris48s
reviewed
Oct 16, 2020
There was a problem hiding this comment.
Nice. Thanks so much for the extra work on splitting these up. Might take a bit to get through them all, but now each review is much less daunting :)
If requires_php is '7.2' or '5.6' or whatever, is that a minimum version i.e: is what this really means the plugin/theme is compatible with PHP >=7.2 or >=5.6?
If so, how about we style it like 
|
No problem, at least now they are easy to do a quick review of for you guys, so should be quicker than trying to do it all as one! Yeah that's right. That's definitely a clearer way to style it, I will get that changed. |
chris48s
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5493, this adds the required php badge for both plugin and themes.
One difference between this and the main PR is that I have now changed one of the tests to a mock, as the live data I was using has changed and no longer works for the test, and I am struggling to find any live data to replace it with.
To help with this, I have refactored some of the test code to help facilitate this.