Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Dockerfile to use official node image instead #539

Merged
merged 1 commit into from
Oct 7, 2015
Merged

Fix broken Dockerfile to use official node image instead #539

merged 1 commit into from
Oct 7, 2015

Conversation

andyshinn
Copy link
Contributor

As I was working on #538, I ran the server in Docker. But the default Dockerfile was broken. I updated to use the official Node image with ONBUILD hooks instead. Also added some information about it in the docs (the two commands I were using together to build and run).

I did try Node 4.0.0, but it looks like some other dependencies are still broken on 4.0.0 (namely socketio/socket.io#2228).

Then run the container:

```console
$ docker run --rm -p 8080:80 shields
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lot of spaces at the end of this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'll re-enable my whitespace line trimmer!

@espadrine
Copy link
Member

Thanks for contributing!

Could you detail how libcairo gets installed? Do the badges get the correct width computation?

@andyshinn
Copy link
Contributor Author

libcairo2 gets installed in the node upstream image, buildpack-deps:jessie (based on Debian Jessie). The specific versions are:

ii  libcairo-gobject2:amd64              1.14.0-2.1              amd64                   Cairo 2D vector graphics library (GObject library)
ii  libcairo-script-interpreter2:amd64   1.14.0-2.1              amd64                   Cairo 2D vector graphics library (script interpreter)
ii  libcairo2:amd64                      1.14.0-2.1              amd64                   Cairo 2D vector graphics library
ii  libcairo2-dev                        1.14.0-2.1              amd64                   Development files for the Cairo 2D graphics library

If widths were off by a pixel or two then I didn't notice, is there an easy way for me to check?

@espadrine espadrine merged commit 5335c87 into badges:master Oct 7, 2015
@espadrine
Copy link
Member

Thanks!

@andyshinn andyshinn deleted the fix_doker_support branch October 7, 2015 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants