Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More example urls and static examples [apm waffle] #2478

Merged
merged 8 commits into from
Dec 11, 2018
Merged

More example urls and static examples [apm waffle] #2478

merged 8 commits into from
Dec 11, 2018

Conversation

paulmelnikow
Copy link
Member

No description provided.

@paulmelnikow paulmelnikow added service-badge New or updated service badge blocker PRs and epics which block other work labels Dec 8, 2018
@paulmelnikow paulmelnikow changed the title More example urls [apm waffle] More example urls and static examples [apm waffle] Dec 8, 2018
paulmelnikow
paulmelnikow commented Dec 8, 2018
View reviewed changes
services/github/github-followers.service.js Outdated
staticPreview: {
label: 'Follow',
message: '150',
// style: 'social',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ This probably needs to be fixed before this is merged. Or else this one could be reverted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #2479. Think I'll just reset it for now.

@shields-ci
Copy link

shields-ci commented Dec 8, 2018 •
edited
Loading

Warnings
⚠️ This PR modified service code for apm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cocoapods but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cpan but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cran but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for dub but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bower but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for jira but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for npm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for packagist but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for php-eye but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for pypi but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against c0d586a

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2478 December 8, 2018 18:26 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2478 December 8, 2018 21:10 Inactive
@paulmelnikow paulmelnikow mentioned this pull request Dec 10, 2018
Closed
12 tasks
PyvesB
PyvesB previously approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a read through and only spotted a minor detail. Good to ship otherwise!

services/jira/jira-issue.service.js Outdated
@@ -19,7 +19,17 @@ module.exports = class JiraIssue extends LegacyService {
return [
{
title: 'JIRA issue',
previewUrl: 'https/issues.apache.org/jira/KAFKA-2896',
pattern: ':protocol/:hostAndPath*/:issueKey',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably doesn't matter much as it's the example pattern, however wouldn't we be expecting :hostAndPath+ rather than :hostAndPath*?

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2478 December 11, 2018 20:59 Inactive
@paulmelnikow paulmelnikow merged commit 88c8b0e into master Dec 11, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the more-example-urls branch December 11, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
blocker PRs and epics which block other work service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @PyvesB