Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache matrix badges for 4 hours #10778

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

chris48s
Copy link
Member

Refs #10776

This isn't a fix, but one of the things that came up in that issue is we should be caching this for a lot longer. The current cacheLength of 30 seconds is likely a copy & paste from elsewhere rather than a sensible value for this badge.

@chris48s chris48s added the service-badge New or updated service badge label Dec 31, 2024
Copy link
Contributor

Warnings
⚠️ This PR modified service code for matrix but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 67de940

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good first step!

@chris48s chris48s added this pull request to the merge queue Jan 1, 2025
Merged via the queue into badges:master with commit 3daef19 Jan 1, 2025
24 checks passed
@chris48s chris48s deleted the 10776-matrix-cache branch January 1, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants