Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto-sized logo sizes #10764

Merged
merged 1 commit into from
Dec 29, 2024
Merged

fix auto-sized logo sizes #10764

merged 1 commit into from
Dec 29, 2024

Conversation

LitoMore
Copy link
Contributor

Fixes #10549

Copy link
Contributor

Warnings
⚠️

This PR modified helper functions in lib/ but not accompanying tests.
That's okay so long as it's refactoring existing code.

Messages
📖 ✨ Thanks for your contribution to Shields, @LitoMore!

Generated by 🚫 dangerJS against cc33278

Copy link
Member

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise it looks good, i run it and i see it works great:
http://localhost/badge/test-me-green?logo=amd&logoSize=auto
image
http://localhost/badge/test-me-green?logo=fineco&logoSize=auto
image

But design wise do we want to break consistency for badges width?
I understand we already got a conclusion for this at #8372 & #9191 that as long as its opt in thats alright.

I would like to hear what other maintainers think about this.

@LitoMore
Copy link
Contributor Author

LitoMore commented Dec 29, 2024

Each logo has its different aspect ratio, so we can't make all icons consistent.





If you mean the width, then we need to consider adding logoWidth back so that users can adjust the width themselves.

Copy link
Contributor

🚀 Updated review app: https://pr-10764-badges-shields.fly.dev

@chris48s
Copy link
Member

chris48s commented Dec 29, 2024

This seems like a pretty straightforward fix to the existing functionality. The auto size as it stands gives an inconsistent width by design.

@chris48s chris48s added this pull request to the merge queue Dec 29, 2024
Merged via the queue into badges:master with commit 00c73c8 Dec 29, 2024
24 checks passed
@LitoMore LitoMore deleted the fix-logo-size branch December 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logoSize sometimes makes logo bigger, other times smaller
3 participants