Use ellipsis when many versions returned for [ModrinthGameVersions] #10350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'm fine with this. Do you have any thoughts on the slightly more involved solution I mentioned in #10346 (comment) ? |
chris48s
approved these changes
Jul 13, 2024
I figured I'd go for the simple solution first. If there's appetite from the community for a more fancy solution, I'm happy to refine things. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10346.
To make sure the ellipsis falls in the "middle", the list of game versions must be sorted. All the examples I've tried seem to return sorted results from the API, so I'm running under that assumption and have kept the implementation simple. We can always revisit later if need-be.