forked from intel/llvm
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SYCL] Add barrier before leader guard in LowerWGSCope pass (intel#2208)
Currently barrier is added only to merge basic block. But barrier must be added before leader guard too. As an example, let's consider the following pseudo code which is generated by LowerWGScope: 1 __local int *done; 2 kernel test() { 3 int done_wi; 4 int count = 0; 5 do { 6 count++; 7 if (get_local_linear_id() == 0) 8 *done = (count == 2); 9 barrier(CLK_LOCAL_MEM_FENCE); 10 done_wi = *done; 11 } while (!done_wi); 12 } Step 1. All WIs execute stmt 3 - stmt 9. This is the first time all WIs encounter the barrier. Step 2. WI0 execute stmt 10 - stmt 11 and this time done is false, and then execute stmt 5 - stmt 9, it set done to true. This is the second time WI0 encounter the barrier. Step 3. Other WIs begin executing stmt 10 - stmt 11 they will see done is true so they can't reach barrier now. To resolve this problem barrier must be added before leader guard: ... barrier(CLK_LOCAL_MEM_FENCE); if (get_local_linear_id() == 0) ... Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
- Loading branch information
Showing
6 changed files
with
74 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py | ||
; RUN: opt < %s -LowerWGScope -S | FileCheck %s | ||
|
||
%struct.snork = type { i32 } | ||
%struct.eggs = type { i8 } | ||
%struct.snork.0 = type { %struct.widget, %struct.widget, %struct.widget, %struct.ham } | ||
%struct.widget = type { %struct.wibble } | ||
%struct.wibble = type { [3 x i64] } | ||
%struct.ham = type { %struct.wibble } | ||
|
||
@global = internal addrspace(3) global [12 x %struct.snork] zeroinitializer, align 4 | ||
|
||
; CHECK: @[[WG_NEXT:[a-zA-Z0-9_.]+]] = internal unnamed_addr addrspace(3) global %struct.snork addrspace(4)* undef, align 8 | ||
; CHECK: @[[WG_DONE:[a-zA-Z0-9_.]+]] = internal unnamed_addr addrspace(3) global i1 undef, align 1 | ||
|
||
define internal spir_func void @spam(%struct.eggs addrspace(4)* %arg, %struct.snork.0* byval(%struct.snork.0) align 8 %arg1) align 2 !work_group_scope !0 { | ||
; CHECK: arrayctor.loop: | ||
; CHECK-NEXT: [[ARRAYCTOR_CUR:%.*]] = phi [[STRUCT_SNORK:%.*]] addrspace(4)* [ getelementptr inbounds ([12 x %struct.snork], [12 x %struct.snork] addrspace(4)* addrspacecast ([12 x %struct.snork] addrspace(3)* @global to [12 x %struct.snork] addrspace(4)*), i32 0, i32 0), [[WG_CF:%.*]] ], [ [[WG_VAL_ARRAYCTOR_NEXT:%.*]], [[WG_CF2:%.*]] ] | ||
; CHECK-NEXT: [[TMP4:%.*]] = load i64, i64 addrspace(1)* @__spirv_BuiltInLocalInvocationIndex, align 4 | ||
; CHECK-NEXT: call void @_Z22__spirv_ControlBarrierjjj(i32 2, i32 2, i32 272) | ||
; CHECK-NEXT: [[CMPZ3:%.*]] = icmp eq i64 [[TMP4]], 0 | ||
; CHECK-NEXT: br i1 [[CMPZ3]], label [[WG_LEADER1:%.*]], label [[WG_CF2]] | ||
; CHECK: wg_leader1: | ||
; CHECK-NEXT: call spir_func void @bar(%struct.snork addrspace(4)* [[ARRAYCTOR_CUR]]) | ||
; CHECK-NEXT: [[ARRAYCTOR_NEXT:%.*]] = getelementptr inbounds [[STRUCT_SNORK]], [[STRUCT_SNORK]] addrspace(4)* [[ARRAYCTOR_CUR]], i64 1 | ||
; CHECK-NEXT: store [[STRUCT_SNORK]] addrspace(4)* [[ARRAYCTOR_NEXT]], [[STRUCT_SNORK]] addrspace(4)* addrspace(3)* @[[WG_NEXT]], align 8 | ||
; CHECK-NEXT: [[ARRAYCTOR_DONE:%.*]] = icmp eq [[STRUCT_SNORK]] addrspace(4)* [[ARRAYCTOR_NEXT]], getelementptr inbounds (%struct.snork, [[STRUCT_SNORK]] addrspace(4)* getelementptr inbounds ([12 x %struct.snork], [12 x %struct.snork] addrspace(4)* addrspacecast ([12 x %struct.snork] addrspace(3)* @global to [12 x %struct.snork] addrspace(4)*), i32 0, i32 0), i64 12) | ||
; CHECK-NEXT: store i1 [[ARRAYCTOR_DONE]], i1 addrspace(3)* @[[WG_DONE]], align 1 | ||
; CHECK-NEXT: br label [[WG_CF2]] | ||
; CHECK: wg_cf2: | ||
; CHECK-NEXT: call void @_Z22__spirv_ControlBarrierjjj(i32 2, i32 2, i32 272) #0 | ||
; CHECK-NEXT: [[WG_VAL_ARRAYCTOR_DONE:%.*]] = load i1, i1 addrspace(3)* @[[WG_DONE]], align 1 | ||
; CHECK-NEXT: [[WG_VAL_ARRAYCTOR_NEXT]] = load [[STRUCT_SNORK]] addrspace(4)*, [[STRUCT_SNORK]] addrspace(4)* addrspace(3)* @[[WG_NEXT]], align 8 | ||
; CHECK-NEXT: br i1 [[WG_VAL_ARRAYCTOR_DONE]], label [[ARRAYCTOR_CONT:%.*]], label [[ARRAYCTOR_LOOP:%.*]] | ||
; CHECK: arrayctor.cont: | ||
; CHECK-NEXT: ret void | ||
; | ||
entry: | ||
%tmp = alloca %struct.eggs addrspace(4)*, align 8 | ||
store %struct.eggs addrspace(4)* %arg, %struct.eggs addrspace(4)** %tmp, align 8 | ||
%tmp2 = load %struct.eggs addrspace(4)*, %struct.eggs addrspace(4)** %tmp, align 8 | ||
br label %arrayctor.loop | ||
|
||
arrayctor.loop: ; preds = %arrayctor.loop, %entry | ||
%arrayctor.cur = phi %struct.snork addrspace(4)* [ getelementptr inbounds ([12 x %struct.snork], [12 x %struct.snork] addrspace(4)* addrspacecast ([12 x %struct.snork] addrspace(3)* @global to [12 x %struct.snork] addrspace(4)*), i32 0, i32 0), %entry ], [ %arrayctor.next, %arrayctor.loop ] | ||
call spir_func void @bar(%struct.snork addrspace(4)* %arrayctor.cur) | ||
%arrayctor.next = getelementptr inbounds %struct.snork, %struct.snork addrspace(4)* %arrayctor.cur, i64 1 | ||
%arrayctor.done = icmp eq %struct.snork addrspace(4)* %arrayctor.next, getelementptr inbounds (%struct.snork, %struct.snork addrspace(4)* getelementptr inbounds ([12 x %struct.snork], [12 x %struct.snork] addrspace(4)* addrspacecast ([12 x %struct.snork] addrspace(3)* @global to [12 x %struct.snork] addrspace(4)*), i32 0, i32 0), i64 12) | ||
br i1 %arrayctor.done, label %arrayctor.cont, label %arrayctor.loop | ||
|
||
arrayctor.cont: ; preds = %arrayctor.loop | ||
ret void | ||
} | ||
|
||
define linkonce_odr dso_local spir_func void @bar(%struct.snork addrspace(4)* %arg) unnamed_addr align 2 { | ||
bb: | ||
%tmp = alloca %struct.snork addrspace(4)*, align 8 | ||
store %struct.snork addrspace(4)* %arg, %struct.snork addrspace(4)** %tmp, align 8 | ||
%tmp1 = load %struct.snork addrspace(4)*, %struct.snork addrspace(4)** %tmp, align 8 | ||
%tmp2 = getelementptr inbounds %struct.snork, %struct.snork addrspace(4)* %tmp1, i32 0, i32 0 | ||
store i32 0, i32 addrspace(4)* %tmp2, align 4 | ||
ret void | ||
} | ||
|
||
!0 = !{} |