feat(pnjs): load progress with less queries #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joelhooks
commented
Jul 30, 2024
joelhooks
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joelhooks
commented
Jul 30, 2024
Comment on lines
+1022
to
+1051
| const results: any = await client.execute(sql` | ||
| SELECT | ||
| cr.id AS resource_id, | ||
| cr.type AS resource_type, | ||
| cr.fields->>'$.slug' AS resource_slug, | ||
| rp.completedAt AS completed_at | ||
| FROM | ||
| ContentResource workshop | ||
| LEFT JOIN | ||
| ContentResourceResource crr1 ON workshop.id = crr1.resourceOfId | ||
| LEFT JOIN | ||
| ContentResource cr1 ON cr1.id = crr1.resourceId | ||
| LEFT JOIN | ||
| ContentResourceResource crr2 ON cr1.id = crr2.resourceOfId | ||
| LEFT JOIN | ||
| ContentResource cr2 ON cr2.id = crr2.resourceId | ||
| LEFT JOIN | ||
| ResourceProgress rp ON rp.resourceId = COALESCE(cr2.id, cr1.id) AND rp.userId = ${user.id} | ||
| CROSS JOIN | ||
| ContentResource cr | ||
| WHERE | ||
| (workshop.id = ${moduleIdOrSlug} OR workshop.fields->>'$.slug' = ${moduleIdOrSlug}) | ||
| AND ( | ||
| (cr.id = cr1.id AND cr1.type IN ('lesson', 'exercise')) | ||
| OR (cr.id = cr2.id AND cr2.type IN ('lesson', 'exercise')) | ||
| ) | ||
| ORDER BY | ||
| COALESCE(crr1.position, 0), | ||
| COALESCE(crr2.position, 0); | ||
| `) |
There was a problem hiding this comment.
less querying and data to get what we want
joelhooks
deleted the
joel/pnjs-33-improve-performance-of-progress-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.