Improve audio latency #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As standardized-audio-context doesn't export the outputLatency property, attempt to fetch it from the native AudioContext, if exists. Resolves large playback differences between SnapWeb and other SnapCast clients.
With "playback" latency, the outputLatency might vary quite extensively on some platforms and sound servers. Using interactive reduces the overall latency and also seems to increase the output latency stability.
|
Thanks, testing is always a problem without a QA team, most users avoid versions that are tagged as beta... |
|
The TS error should be resolved by the latest commit. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two improvements to the SnapWeb audio stream latency handling.
As the
standardized-audio-contextdoesn't expose theoutputLatencyproperty, the first commits adds a getter that tries to fetch theAudioContext.outputLatencyfrom the native AudioContext, if it exists. It improves the sync between SnapWeb and other (non-web) Snapcast clients dramatically.The second commit sets the latencyHint of the AudioContext to "interactive". This not only reduces the output latency on most systems, but seems to make the output latency also more stable. On some platforms, the output latency varies over time depending on system load and other factors. Using "interactive" seems to make this a little less likely.
Tested on recent Chrome and Firefox on Linux. More tests would probably be a good idea.