Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use of (https) reverse proxies by default #25

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

patagonaa
Copy link
Contributor

Use the snapweb URL for connecting to the websockets by default.
This allows running snapweb behind a reverse proxy but might break existing installations if snapweb is not running in the snapserver's web server.

fixes #21

@badaix
Copy link
Owner

badaix commented Nov 22, 2020

In which scenario this change would break an existing installation and how could this be fixed?

@patagonaa
Copy link
Contributor Author

If you're running snapweb under a different web server than snapcast (like, say, snapweb on port 80 and snapserver websocket on 1780) this PR would break the installation (because snapweb would try to connect the websocket to port 80 instead of hard-coded 1780 like it used to).

I'm not sure if this is something people do/did, and the solution for them would be to either move snapweb to the snapservers' web server or to edit their config.js

@badaix
Copy link
Owner

badaix commented Nov 22, 2020

Understood, thanks 👍

@badaix badaix merged commit 57dec92 into badaix:develop Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants