Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc code improvements #24

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Conversation

patagonaa
Copy link
Contributor

remove unnecessary casts, use JSON.stringify instead of building JSON by hand

@badaix
Copy link
Owner

badaix commented Nov 22, 2020

thanks! Throwing an error instead of a blind cast without further checks for null does indeed make more sense and looks cleaner :)

@badaix badaix merged commit c93c97a into badaix:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants