Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes the size and font-size mixins #212

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Conversation

aurooba
Copy link
Collaborator

@aurooba aurooba commented May 31, 2023

Closes #179

Open for discussion still, but in case you agree, this PR removes the size and font-size mixins

@aurooba aurooba requested a review from bacoords May 31, 2023 23:47
@bacoords
Copy link
Owner

bacoords commented Jun 1, 2023

Agreed but per my other comments on #179 we either need to set up ALL the padding and margin mixins or not. And we have two margin-y mixins

@bacoords bacoords merged commit 82912ac into develop Apr 11, 2024
1 check passed
@bacoords bacoords deleted the remove/unnecessary-mixins branch April 11, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In mixins we also have two mixins that aren't used
2 participants