Add light theme and listen for system theme changes #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out JUCE caches some text colors and we need to call applyColourToAllText. Also needed to set the menuPicker colors in darkModeSettingChanged, and check for nullptr to avoid a crash if we haven't opened the picker yet. This should be good to go, although we may want to adjust some of the light mode colors as they are just an inversion of dark mode. |
|
Looks great. I'm going to pull and tweak just a touch before merge - people are starting to use the end product this weekend. Thank you so much for doing this! |
- Update the param label typein when colors change too - Make it so you have an always dark/always light option as well as follow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a fix before merging.
Currently some changes are not happening until relaunch (when switching system theme), not sure why. The worst one is the documentation text color.
Added an enum to map colors. There are 2 methods using setColour to adjust the theme, and the JUCE dark mode listener to set initial theme and respond to system changes for now. Colours are set using findColour.