Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airwindows Consolidated: Cycling plugins with buttons will skip a plugin every few plugins #62

Closed
mthierman opened this issue May 4, 2024 · 2 comments · Fixed by #64
Closed

Airwindows Consolidated: Cycling plugins with buttons will skip a plugin every few plugins #62

mthierman opened this issue May 4, 2024 · 2 comments · Fixed by #64

Comments

@mthierman
Copy link
Contributor

Cycle up or down through the plugins, after 2-4 plugins it may skip a plugin. Seems to be worse if you go up and down in the list instead of one direction.
@baconpaul
Copy link
Owner

Oh I wonder if my long hold timer is wonky. I bet it is

@baconpaul
Copy link
Owner

Yeah

airwin2rack/src-juce/AWConsolidatedEditor.cpp

Line 292 in 67c2a5c

void startJogHold(int dir)
should be a click counter not a bool

baconpaul added a commit that referenced this issue May 4, 2024
@baconpaul
Fix jog-hold misfire in jog effect selectors
9e1a3df 
A simple bool on our timer meant if a jog hold fired while
the subsequent mouse was down you would get a double bump.
A simple 'jogging or not' is not enough but a click counter
does the trick, so move to that.

Closes #62
@baconpaul baconpaul mentioned this issue May 4, 2024
Merged
baconpaul added a commit that referenced this issue May 4, 2024
@baconpaul
Fix jog-hold misfire in jog effect selectors (#64)
22d7c75 
A simple bool on our timer meant if a jog hold fired while
the subsequent mouse was down you would get a double bump.
A simple 'jogging or not' is not enough but a click counter
does the trick, so move to that.

Closes #62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix jog-hold misfire in jog effect selectors baconpaul/airwin2rack
2 participants
@baconpaul @mthierman