Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Repos #7

Open
orangewolf opened this issue Aug 20, 2016 · 5 comments
Open

Private Repos #7

orangewolf opened this issue Aug 20, 2016 · 5 comments

Comments

@orangewolf
Copy link

I'm getting permissions issue when using this on a private fork of a private repo (hook is on the child, not the parent). Is that expected to work?

This is the message
Status 200

Uhh, error: {"message":"Validation Failed","errors":[{"message":"The listed users and repositories cannot be searched either because the resources do not exist or you do not have permission to view them.","resource":"Search","field":"q","code":"invalid"}],"documentation_url":"https://developer.github.com/v3/search/"}

@1egoman
Copy link
Collaborator

1egoman commented Aug 20, 2016

@orangewolf This is happening because backstroke doesn't have permission to view the repository and its issues (Backstroke checks a child repository's issues to see if the repo has opted out, and if it has, then it won't send a PR to that repo). I didn't really design Backstroke to be used in a private repo, unfortunately. I'm planning on rewriting the project over the next few months, and private repos will be one of the things I'll ensure to support.

@orangewolf
Copy link
Author

Thanks Ryan,
That totally makes sense. I may play with what it would take to support private repos.

On Aug 20, 2016, 15:11 -0700, Ryan Gaus notifications@github.com, wrote:

@orangewolf (https://github.com/orangewolf) This is happening because backstroke doesn't have permission to view the repository and its issues (Backstroke checks a child repository's issues to see if the repo has opted out, and if it has, then it won't send a PR to that repo). I didn't really design Backstroke to be used in a private repo, unfortunately. I'm planning on rewriting the project over the next few months, and private repos will be one of the things I'll ensure to support.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#7 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/ABAW8B792QpZoaOqGWen-W4DWK32JkuRks5qh3upgaJpZM4JpKkb).

@1egoman 1egoman added the in-v2 label Aug 22, 2016
@1egoman 1egoman removed the in-v2 label Oct 7, 2017
@1egoman
Copy link
Collaborator

1egoman commented Oct 7, 2017

This is going to be one of my next focuses, now that I've released #66 .

@vikhik
Copy link

vikhik commented Nov 7, 2017

I have a related (?) issue when trying to update my (private) fork of EpicGames/UnrealEngine (which requires access, and it appears that Backstroke has it), which is vikhik/UnrealEngine:

Error in syncing link.
Couldn't search issues on repository vikhik/UnrealEngine: {"message":"Not Found","documentation_url":"https://developer.github.com/v3/issues/#list-issues-for-a-repository"}

EDIT: It appeared that Issues was turned off on my repo. I've turned them on but I'm still getting the same error.

@1egoman
Copy link
Collaborator

1egoman commented Nov 7, 2017

@vikhik Backstroke doesn't support private repositories. There are workarounds (such as adding the backstroke-bot user to a repository) but those aren't supported given that there are no tests for these scenarios and this adds a lot of security concerns that frankly I don't want to have to deal with.

Potentially, private repositories could land in the future, but first, the codebase and deployment need to be updated with private code in mind and they'll probably cost a minimal amount of money to help pay for the additional infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants