packages,plugins: point types to src/ for development #864
Conversation
| const pkgPath = paths.resolveTarget('package.json'); | ||
|
|
||
| const pkg = await fs.readJson(pkgPath); | ||
| pkg.types = 'src/index.ts'; |
There was a problem hiding this comment.
I guess this could have been served a bit cleaner as doing a backup in a secret dotfile, and restoring from that backup. That would not give unintended changes if the user has a slightly different thing going on in their file (other indent or whatever)
There was a problem hiding this comment.
And I presume there was no way to make this happen silently inside build? It would just be nice to not have so much boilerplate in the package files.
There was a problem hiding this comment.
yeah opted for just making sure type field exists everywhere instead of backup/restore. That would've been a bit annoying to deal with too imo, especially since the postpack script doesn't work 😁.
And no, afaik there's no way to silently hook into the process. I mean we could modify the yarn implementation we check into the repo, but nooooooooooo x)
First and most obvious build setup fix coming out of #834
So my initial approach was to do this through publishConfig, docs for that are here. Turns out that their main docs point to the unreleased yarn v2 though, and that feature doesn't exist yet ¯\(ツ)/¯.
Looked though some 10 monrepos you there, mostly from https://github.com/brillout/awesome-react-components. Can't find any repo that has separate types config for published packages, so no prior art for this T_T
I'm thinking that adding pre-/post-pack scripts is the cleanest way to go about this for now. If we switch to yarn 2 me might be able to remove them. Or if we switch to pnpm who's had the feature for ages 😁
The postpack script also doesn't get called right now, bug in yarn, yarnpkg/yarn#7924, so publishing or trying out pack locally leaves some garbage in the packages.