-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update releases, update install process, add extra outputs for porter install #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
it is broken for now due to a Porter bug Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
morey-tech
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits, but otherwise it looks good!
Co-authored-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Boris Kurktchiev <kurktchiev@gmail.com>
partially addresses #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a push, but it goes through and sets up our ability to use variables to control versions of components.
It also adds some sanity checks and clean-ups for the installation process.
Finally, it adds some extra outputs that are useful: