Seport local #1
Open
Seport local #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What s your plan with this? seport_local was just a WIP branch with POC. I didn't plan to use it for anything else. |
I think linux-system-roles#123 should replace linux-system-roles#122, and this PR is an addition to your linux-system-roles#123 |
|
I see. Using this PR in the other PR seems to unnecessary complicates things. I don't really insist on my commit in linux-system-roles#123 especially when it needs to be fixed. It was just a proof of concept. Feel free to take seport from collections and do all necessary changes in your branch and PR. |
richm
force-pushed
the
seport_local
branch
3 times, most recently
from
9faa76e to
1e7aeed
Compare
richm
force-pushed
the
seport_local
branch
2 times, most recently
from
0240336 to
ca9dabd
Compare
`community.general.seport` has recently added the `local` parameter
which is now supported by the role.
- `local: true`:
* `state: present` enforces change to be made even though the
port mapping could already exists in built in policy
* `state: absent` would remove only local modification and would not
try to remove builtin mapping.
The role vendors-in the seport module as `local_seport`, because otherwise
it is too difficult to support both Ansible 2.9 and ansible-core. We will
revisit this when Ansible 2.9 is EOL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.