Track terms of use #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
lgtm apart from the naming. I believe we should be explicit with the naming here, i.e. denote that this is just a method for logging terms acceptance. Most of my comments are recommendations about this naming update, but I did not add them everywhere, please make sure all places are updated accordingly.
jeremy-babylonlabs
force-pushed
the
85-track-terms-of-use
branch
from
5d48e43 to
aeefa68
Compare
jeremy-babylonlabs
force-pushed
the
85-track-terms-of-use
branch
from
aeefa68 to
524da15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85