Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return IsEligibleForTransition in delegation #139

Merged
merged 4 commits into from
Nov 25, 2024
Merged

feat: return IsEligibleForTransition in delegation #139

merged 4 commits into from
Nov 25, 2024

Conversation

jrwbabylonlab
Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab commented Nov 25, 2024 •
edited
Loading

To enable the transition, need to add:

delegation_transition:
   eligible_before_btc_height: 123,
   allow_list_expiration_height: 456

@jrwbabylonlab jrwbabylonlab force-pushed the gradual-transition-of-phase-1 branch from 9339baa to d82849b Compare November 25, 2024 05:49
gusin13
gusin13 reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@gusin13 gusin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, some initial comments

internal/shared/config/delegation_transition.go Outdated Show resolved Hide resolved
internal/indexer/db/client/last_processed_height.go Outdated Show resolved Hide resolved
@jrwbabylonlab jrwbabylonlab merged commit 4ba5e0c into main Nov 25, 2024
11 checks passed
@jrwbabylonlab jrwbabylonlab deleted the gradual-transition-of-phase-1 branch November 25, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusin13 gusin13 gusin13 approved these changes

@jeremy-babylonlabs jeremy-babylonlabs jeremy-babylonlabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrwbabylonlab @gusin13 @jeremy-babylonlabs