Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add integration documentation #274

Merged
merged 6 commits into from
Aug 16, 2024
Merged

feat: add integration documentation #274

merged 6 commits into from
Aug 16, 2024

Conversation

jrwbabylonlab
Copy link
Contributor

No description provided.

gitferry
gitferry reviewed Aug 13, 2024
View reviewed changes
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
@jrwbabylonlab jrwbabylonlab requested a review from gitferry August 14, 2024 03:27
gitferry
gitferry previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently all the api urls pointing to testnet under babylonchain. Do we want to change that later? Other than that, lgtm!

@jrwbabylonlab
Copy link
Contributor Author

Currently all the api urls pointing to testnet under babylonchain. Do we want to change that later? Other than that, lgtm!

yep. change it when we have the url

vitsalis
vitsalis previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minor comments

bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
@jrwbabylonlab jrwbabylonlab dismissed stale reviews from vitsalis and gitferry via b8d4950 August 15, 2024 01:29
@jrwbabylonlab jrwbabylonlab force-pushed the add-integration-doc branch 2 times, most recently from b8d4950 to 03213e1 Compare August 16, 2024 08:31
gitferry
gitferry previously approved these changes Aug 16, 2024
View reviewed changes
vitsalis
vitsalis previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly recommendations on adding versions on links. While these will need to be updated with new minor version updates, I believe we should have control on what versions are listed in our docs as we are responsible for ensuring compatibility within them.

bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/staking-backend.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
bbn-1/integration/wallet.md Outdated Show resolved Hide resolved
@jrwbabylonlab jrwbabylonlab dismissed stale reviews from vitsalis and gitferry via 1da1189 August 16, 2024 10:43
@vitsalis vitsalis merged commit 41a93cd into main Aug 16, 2024
@vitsalis vitsalis deleted the add-integration-doc branch August 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitsalis vitsalis vitsalis approved these changes

@gitferry gitferry gitferry left review comments

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrwbabylonlab @vitsalis @gitferry