chore: fix small bias in EOTS private key generation #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
changed the title
|
|
||
| // increase iteration count and sample again until overflow does not | ||
| // happen. It is fine as the chance of overflow is very small (2^-128) | ||
| if overflow := randScalar.SetByteSlice(randPre); !overflow { |
There was a problem hiding this comment.
I think we also need to check if the generated scalar is not 0. Good example of the generation can be find in decred library itself - https://github.com/decred/dcrd/blob/172eeb5fe1493e1d5cff6dc304c94de5befd0d21/dcrec/secp256k1/nonce.go#L245
gitferry
force-pushed
the
gai/fix-bias-randomness-generation
branch
from
61063d7 to
d92c928
Compare
Lazar955
approved these changes
Feb 10, 2025
KonradStaniec
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/babylonlabs-io/pm/issues/191