-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: check if tx index enabled #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is specific to babylon so we should do the check when we initiate the babylon client, i.e.,
func NewBabylonController( |
This is good point! Though one thing is, that functions starting with |
Make sense. Also agree with @KonradStaniec regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
clientcontroller/interface.go
Outdated
@@ -89,6 +91,8 @@ type ClientController interface { | |||
// the value zero should be returned. | |||
QueryFinalityActivationBlockHeight() (uint64, error) | |||
|
|||
NodeTxIndexEnabled() (bool, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed
No description provided.