Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new command to validate exported pop #297

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

RafilxTenfen
Copy link
Contributor

No description provided.

Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it validate a JSON file? Better if we can make pop export to generate a JSON file

@RafilxTenfen
Copy link
Contributor Author

Can we make it validate a JSON file? Better if we can make pop export to generate a JSON file

we could make it a file, but also with just a few things more in the shell it could direct the output to a file like eotsd pop export > file_path and on the validate pop validate $(cat file_path)

Let me know if outputting to a file and reading from it is still needed, I will address in another PR

@RafilxTenfen RafilxTenfen merged commit 548f278 into main Jan 24, 2025
15 checks passed
@RafilxTenfen RafilxTenfen deleted the rafilx/add-validate-pop branch January 24, 2025 11:19
RafilxTenfen added a commit that referenced this pull request Jan 24, 2025
#297 

Tag v0.4.3 should be pushed after this merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants