Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incentive proto v1 check #442

Open
RafilxTenfen opened this issue Jan 24, 2025 · 0 comments
Open

incentive proto v1 check #442

RafilxTenfen opened this issue Jan 24, 2025 · 0 comments
Assignees
@RafilxTenfen

Comments

@RafilxTenfen
Copy link
Contributor

All the protos have /proto/babylon/<module-name>/v1/files
But the incentive module is /proto/babylon/incentive/files

Verify if it is possible to rename it without breaking state

First thought is if that changes the msg type URL
@RafilxTenfen RafilxTenfen self-assigned this Jan 24, 2025
@RafilxTenfen RafilxTenfen mentioned this issue Jan 24, 2025
Merged
RafilxTenfen added a commit that referenced this issue Jan 27, 2025
@RafilxTenfen
fix: swagger doc gen incentive v1 (#443)
1038c81 
All of our modules in proto have `/proto/babylon/<module-name>/v1/files`
but incentives does not have `v1` it is defined as
`/proto/babylon/incentive/files`

Future investigation to try to add `v1` to the incentive proto will be
done at #442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafilxTenfen RafilxTenfen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RafilxTenfen