Make docs nav sidebar sticky, add on-page nav #1582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for babel-new ready! Built with commit b666395 |
|
Really cool! |
xtuc
approved these changes
Feb 23, 2018
|
I wonder if this could be upstreamed as a config option to the Docusaurus core? Folks have been asking for something like this. |
|
@JoelMarcey Yeah that would be better and I guess that's a common use case. Thanks! |
|
Yeah, I second upstreaming this to Docusaurus! |
|
An upstream PR is being worked on by @microbouji. 🎉 |
|
Yep, looks like this will be part of docusaurus soon 🎉. Thanks for quick reviews @JoelMarcey! |
|
@microbouji awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commited with no-verify as I was getting some flow errors from the repl?
This fixes #1536
I've made no visual changes to the docs sidebar.
Idea for the future: could make doc categories in the left sidebar collapsible and/or add pjax to save scroll location like https://reasonml.github.io/reason-react/docs/en/installation.html