refactor(tests) - Tests to fixtures - mergeSiblingVars #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
reviewed
Dec 15, 2017
| @@ -0,0 +1,2 @@ | |||
| let i = 0; | |||
There was a problem hiding this comment.
rename file - block-scoped-for ?
boopathi
reviewed
Dec 15, 2017
| @@ -0,0 +1,2 @@ | |||
| const j = 0; | |||
| for (const x = 0; ; ) console.log(j + x); | |||
There was a problem hiding this comment.
move this to previous test - as it tests block scoped vars merged to for loop
boopathi
reviewed
Dec 15, 2017
| @@ -0,0 +1,6 @@ | |||
| for (var i = 0; i < 0; i++) { | |||
There was a problem hiding this comment.
filename: destructuring-var-lift ?
|
Looks like formatting errors - $(yarn bin)/jest packages/babel-plugin-merge-sibling-variables -- --update-fixtureswill fix them |
vigneshshanmugam
force-pushed
the
fixtures-merge-sib-vars
branch
from
9ecea2e to
13816e3
Compare
boopathi
approved these changes
Dec 18, 2017
boopathi
added
the
Tag: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.