Node API and CLI #507

boopathi · 2017-04-19T12:27:06Z

codecov · 2017-04-19T12:31:21Z

Codecov Report

Merging #507 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files          34       34           
  Lines        2539     2539           
  Branches      908      908           
=======================================
  Hits         2114     2114           
  Misses        254      254           
  Partials      171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2710cf...fc633c8. Read the comment docs.

sylvesteraswin · 2017-04-21T12:21:47Z

What do you think of using commander to create the cli?

boopathi · 2017-04-24T20:33:12Z

.eslintrc.js

@@ -14,6 +14,7 @@ module.exports = {
  rules: {
    "linebreak-style": ["error", "unix"],
    "no-cond-assign": OFF,
-    "no-case-declarations": OFF
+    "no-case-declarations": OFF,
+    "no-console": ["error", { allow: ["error"] }]


for console.error from fs errors.

process.stderr.write() ?

vigneshshanmugam · 2017-05-08T15:39:49Z

packages/babili/src/cli.js

+    }
+  });
+
+  const files = argv["_"];


only validation i would do extra is to validate the files and check if they are present.. did we need to do anything extra? @boopathi

fs.readFile will already throw if the file is either not present or not read-able. So, I'm not sure if that needs to be separately verified.

Yeah and I did also check ignore the file if it isn't present https://github.com/babel/babili/blob/2b1b16ac05596e65ec77c56a1e3e1b7882991341/packages/babili/src/fs.js#L29

vigneshshanmugam · 2017-05-11T20:41:50Z

packages/babili/src/cli.js

+
+  Options:
+    --out-file, -o          Output to a specific file
+


we should keep a minimal list for the help command.. thoughts? @boopathi

vigneshshanmugam · 2017-05-15T15:06:15Z

package.json

    "roots": [
      "packages"
    ],
-    "transformIgnorePatterns": [


not required. default is node_modules

vigneshshanmugam · 2017-08-09T21:17:26Z

packages/babili/src/fs.js

+      if (outFile === void 0) {
+        process.stdout.write(code + "\n");
+      } else {
+        fs.writeFileSync(path.resolve(outFile), code, "utf-8");


should be changed to outputFileSync

vigneshshanmugam · 2017-08-10T21:58:07Z

packages/babili/__tests__/cli-tests.js

+    expect(spawn(source, "--mangle.topLevel").stdout).toMatchSnapshot();
+  });
+
+  xit("should handle input file and --out-file option", () => {


there is issue with validation options, need to fix it first.

update Add yargs-parser Add key not exist case in options parser Remove deadcode Cleanup options parser Improve filtering input CLI options

cli options and fs add out-file, out-dir and accept alias add small validation for cli set up cli tests and help option add help options and fix stdin fix test cases Add tests for cli file/dir and help option add eslintrc for tests ignore fixtures in test suite update package deps small changes for stdin

Fix up Simplify Fix lint handle default case Fix some tests

Format jest snapshots Fix yarn deps

Remove outFile and outDir from options passed to babili Update snapshot

Update package.json

boopathi added Tag: Breaking Change Pull Request breaks the API Tag: New Feature Pull Request adding a new feature labels Apr 19, 2017

boopathi force-pushed the node-api-0 branch from bf56d7a to b157181 Compare April 24, 2017 09:55

boopathi commented Apr 24, 2017

View reviewed changes

vigneshshanmugam reviewed May 8, 2017

View reviewed changes

vigneshshanmugam force-pushed the node-api-0 branch from f9a118d to 2b1b16a Compare May 8, 2017 15:44

vigneshshanmugam mentioned this pull request May 8, 2017

Babili CLI #429

Closed

vigneshshanmugam force-pushed the node-api-0 branch from 2b1b16a to 9357bd3 Compare May 10, 2017 14:42

boopathi mentioned this pull request May 11, 2017

Example 'keepClassNames' in gulp-babili README is wrong #532

Closed

vigneshshanmugam reviewed May 11, 2017

View reviewed changes

vigneshshanmugam reviewed May 15, 2017

View reviewed changes

package.json

"roots": [

"packages"

],

"transformIgnorePatterns": [

Copy link

Member

vigneshshanmugam May 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required. default is node_modules

vigneshshanmugam force-pushed the node-api-0 branch 2 times, most recently from 3ea64d8 to fc633c8 Compare May 22, 2017 10:18

vigneshshanmugam mentioned this pull request Jun 22, 2017

Add option to ignore asm.js code #599

Open

vigneshshanmugam force-pushed the node-api-0 branch from fc633c8 to ac9fe06 Compare August 6, 2017 19:12

vigneshshanmugam reviewed Aug 9, 2017

View reviewed changes

boopathi force-pushed the node-api-0 branch 2 times, most recently from 97e5388 to 2d77c32 Compare August 10, 2017 09:56

vigneshshanmugam force-pushed the node-api-0 branch from 0e2648f to b9b4844 Compare August 10, 2017 21:57

vigneshshanmugam reviewed Aug 10, 2017

View reviewed changes

boopathi changed the title ~~[WIP] Node API and CLI~~ Node API and CLI Aug 11, 2017

vigneshshanmugam force-pushed the node-api-0 branch 2 times, most recently from 4025eab to 4727cb4 Compare August 11, 2017 12:05

boopathi and others added 5 commits August 11, 2017 14:13

Node API and CLI

43e00b5

update Add yargs-parser Add key not exist case in options parser Remove deadcode Cleanup options parser Improve filtering input CLI options

Async fs

4e6b35e

Fix up Simplify Fix lint handle default case Fix some tests

move to spawnSync from exec to capture stderr, stdout

ac6cd49

Move tests to async

b158348

Format jest snapshots Fix yarn deps

boopathi and others added 2 commits August 11, 2017 14:13

Add node api tests

7d8ee55

Remove outFile and outDir from options passed to babili Update snapshot

use stdin stream and api test

82dfd83

Update package.json

boopathi force-pushed the node-api-0 branch from 9d1ecfb to 82dfd83 Compare August 11, 2017 12:13

boopathi merged commit dd7dc67 into master Aug 11, 2017

boopathi deleted the node-api-0 branch August 11, 2017 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node API and CLI #507

Node API and CLI #507

boopathi commented Apr 19, 2017 •

edited

Loading

codecov bot commented Apr 19, 2017 •

edited

Loading

sylvesteraswin commented Apr 21, 2017

boopathi Apr 24, 2017

vigneshshanmugam Apr 24, 2017

boopathi May 9, 2017 •

edited

Loading

vigneshshanmugam May 8, 2017

boopathi May 9, 2017 •

edited

Loading

vigneshshanmugam May 9, 2017

vigneshshanmugam May 11, 2017

vigneshshanmugam May 15, 2017

vigneshshanmugam Aug 9, 2017

vigneshshanmugam Aug 10, 2017

Node API and CLI #507

Node API and CLI #507

Conversation

boopathi commented Apr 19, 2017 • edited Loading

codecov bot commented Apr 19, 2017 • edited Loading

Codecov Report

sylvesteraswin commented Apr 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boopathi May 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boopathi May 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boopathi commented Apr 19, 2017 •

edited

Loading

codecov bot commented Apr 19, 2017 •

edited

Loading

boopathi May 9, 2017 •

edited

Loading

boopathi May 9, 2017 •

edited

Loading