Upgrade to Babel 7 #487

boopathi · 2017-04-03T15:22:40Z

Review individual commits and ignore formatting commits

Current Bugs:

TypeError: Cannot read property 'getBinding' of null
- node smoke/run.js html-minifier
TypeError: Cannot read property 'isPure' of null
- TypeError: Cannot read property 'isPure' of null #790
- node smoke/run.js jquery
- node smoke/run.js lodash

codecov · 2017-04-03T15:23:55Z

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #487   +/-   ##
======================================
  Coverage    82.8%   82.8%           
======================================
  Files          44      44           
  Lines        2896    2896           
  Branches     1011    1011           
======================================
  Hits         2398    2398           
  Misses        304     304           
  Partials      194     194

Impacted Files	Coverage Δ
...ages/babel-plugin-minify-mangle-names/src/index.js	`82.48% <100%> (ø)`	⬆️
...l-plugin-minify-dead-code-elimination/src/index.js	`85.5% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba29bc5...7718829. Read the comment docs.

hzoo · 2017-04-03T19:17:56Z

package.json

    "babel-eslint": "^7.2.1",
    "babel-jest": "^19.0.0",
-    "babel-plugin-transform-es2015-block-scoping": "^6.23.0",
    "babel-preset-env": "^1.2.2",


there's also a v2.0.0-alpha.3 for this if we want to use

diervo · 2017-06-22T20:55:22Z

Any blocker to push this, apart from probably increment minor version?

hzoo · 2017-06-23T03:02:54Z

If we release as a minor or anything it also means that users using babili as a preset will fail unless they use babel-core 7.0 alpha as well

diervo · 2017-06-23T03:18:58Z

Why don't generate a "next" version instead of "latest" like all of the 7beta packages?

diervo · 2017-07-01T18:02:09Z

@boopathi @hzoo This is preventing me for upgrading all our build process to babel7, and I would argue that many other developers too (to reuse the same AST tree)

I will be happy to maintain a branch in sync with upstream changes if that's required.
Is there any other blockers?
Otherwise I would love to have a resolution on this or a timeframe/plan at least.

kelset · 2017-07-04T16:50:57Z

Any ETA for this PR to be merged?

boopathi · 2017-07-10T18:55:31Z

Waiting to find a way to continue testing packages for babel 6 too. Along with babel-7.

vigneshshanmugam · 2017-09-13T16:29:01Z

Trying out babel-7.0.0-beta.0 version.

vigneshshanmugam · 2017-09-13T16:39:00Z

package.json

@@ -70,5 +71,8 @@
  },
  "workspaces": [
    "packages/*"
-  ]
+  ],
+  "resolutions": {


This is require because

jest-cli uses babel-core: 6 version which is hoisted to the node_modules directory by using yarn workspaces which in turn hoists babel-register: 6

running babel-register with 6 version would break and report this following error which is deprecated in babel 7

TypeError: /Users/vshanmugam/open-source/babili/gulpfile.babel.js: path.arrowFunctionToExpression is not a function at PluginPass.ArrowFunctionExpression (/Users/vshanmugam/open-source/babili/node_modules/babel-plugin-transform-es2015-arrow-functions/lib/index.js:10:14)

remcohaszing · 2017-11-07T20:35:49Z

Some updates:

Official babel-* packages have been renamed to @babel/*.

babel-minify@0.2.0 seems to work after upgrading babel to the namespaced beta packages based on a package-lock.json file, but it seems to break when the lock file is removed and a new one is created. (I encountered this in this project).

As can be seen in the babel-core options, Babel now handles whitespaces internally based on the compact option. This causes most test failures. The output of the tests can be modified by specifying the compact parameter in test-transform.js. Either way, many tests will need some manual whitespace modifications.

Should the babel-7 branch just focus on Babel 7 only and drop support for Babel 6 because of the rename?
Should babel-minify use namespaced packages as well?
Is compact mode (more real) or non compact mode (more readable for tests) preferred?

I may want to try and fix this port, or at least partially, if these questions get answered.

vigneshshanmugam · 2018-02-23T16:55:31Z

packages/babel-plugin-minify-mangle-names/src/scope-tracker.js

+ * Babel-7 returns null if there is no function parent
+ * and uses getProgramParent to get Program
+ */
+function getFunctionParent(path) {


does it make sense to make it to one of the helpers?

diervo · 2018-02-24T18:02:57Z

@boopathi thanks a bunch for rebasing the work, will continue our testing!
Is there anyway we can help get a stable beta branch out soon?

We will be using babili on production shortly, so our team at Salesforce can help with some bugs and contributions whenever possible.

hzoo · 2018-02-24T19:47:44Z

Yeah although I haven't been involved in this particular project for a while I think it should land on master and then make another branch for the old version and start doing releases? This is what we did with v7; we spent a long time making a 7.x branch but it was easier to just develop on master and create a 6.x branch for old code.

(Assuming the tests pass already)

diervo · 2018-02-24T19:56:47Z

That would be awesome!
Yes all tests are passing (at leas the yarn test target), I created my own fork where I'm testing the integration with another project that depends on babel7.

I will report back more issues soon, and some PRs too ;)

We need to make sure the README is clear about what branch and versions maps to what.
Otherwise we will end up in a similar messy situation as Uglify.

vigneshshanmugam · 2018-02-24T20:25:18Z

Yeah although I haven't been involved in this particular project for a while I think it should land on master and then make another branch for the old version and start doing releases? This is what we did with v7; we spent a long time making a 7.x branch but it was easier to just develop on master and create a 6.x branch for old code.

I would say so, Makes it better to do a patch release and backport it to 6 when needed while we work on new features in master.

boopathi · 2018-02-28T21:01:59Z

Master now uses babel-7 🎉

npm install babel-minify@canary should now install babel-7 version (auto published from master).

babel-6 is in 0.3.x branch.

vigneshshanmugam · 2018-02-28T21:20:20Z

Awesome job 🎉 🎉

boopathi added Tag: Breaking Change Pull Request breaks the API and removed Tag: Breaking Change Pull Request breaks the API labels Apr 3, 2017

hzoo reviewed Apr 3, 2017

View reviewed changes

boopathi force-pushed the babel-7 branch from 2866a42 to 161712e Compare April 4, 2017 13:06

boopathi added the Tag: Breaking Change Pull Request breaks the API label Apr 5, 2017

boopathi force-pushed the babel-7 branch from 161712e to 7718829 Compare June 15, 2017 14:40

babel deleted a comment from hzoo Jun 15, 2017

vigneshshanmugam mentioned this pull request Jun 22, 2017

Babili does not work with babel 7 due to clearCache deprecation #600

Closed

boopathi force-pushed the babel-7 branch from 7718829 to 310f9fa Compare July 10, 2017 18:19

boopathi mentioned this pull request Jul 10, 2017

Support babel 7 #625

Merged

vigneshshanmugam mentioned this pull request Aug 26, 2017

Add babel-minify-standalone #679

Open

vigneshshanmugam mentioned this pull request Sep 9, 2017

Add test for multiple var statements #686

Closed

vigneshshanmugam force-pushed the babel-7 branch from 6295e25 to becae5c Compare September 13, 2017 14:14

vigneshshanmugam reviewed Sep 13, 2017

View reviewed changes

xtuc mentioned this pull request Oct 5, 2017

Minify doesn't work in the REPL anymore babel/website#1405

Closed

boopathi force-pushed the babel-7 branch 2 times, most recently from c2cb242 to 592e689 Compare October 9, 2017 14:00

boopathi mentioned this pull request Oct 25, 2017

[BUG] Cannot read property 'add' of undefined #556

Closed

boopathi added the WIP Pull Request is currently Work In Progress label Nov 7, 2017

This was referenced Dec 19, 2017

Processing of quotes in strings is very broken. #308

Open

chore(deps): upgrade deps #765

Merged

boopathi added 11 commits February 20, 2018 02:10

fix: formatting of transform-inline-consecutive-adds

9cd078e

fix: formatting of transform-merge-sibling-variables

fadcb83

fix: formatting transform-property-literals

2f9b186

fix: formatting transform-remove-console

3041133

fix: formatting transform-remove-debugger

abfc6d7

fix: formatting tests for transform-remove-undefined

48afce9

fix: formatting tests for transform-undefined-to-void

4bbeb23

fix: formatting for babel-preset-minify

8de315f

fix: gulp-util deprecations. use Vinyl

0bf77a5

fix: babel-minify package tests

588ba00

fix: formatting tests for minify-replace

8cf9f33

boopathi force-pushed the babel-7 branch from 592e689 to 8cf9f33 Compare February 23, 2018 09:51

boopathi mentioned this pull request Feb 23, 2018

Destructuring assignment fails in 0.2 and 0.3 with babel7 #802

Closed

vigneshshanmugam reviewed Feb 23, 2018

View reviewed changes

Diego and others added 4 commits February 25, 2018 20:48

Upgrade all dependencies to babel7

337563f

fix: path & scope out of sync

363f13c

Remove comments

7948a6c

fix lint errors

50e49ac

boopathi removed the WIP Pull Request is currently Work In Progress label Feb 28, 2018

boopathi changed the title ~~[WIP] Upgrade to Babel 7~~ Upgrade to Babel 7 Feb 28, 2018

try fix windows ci

ea95a22

boopathi merged commit f95869d into master Feb 28, 2018

boopathi deleted the babel-7 branch February 28, 2018 21:00

vigneshshanmugam mentioned this pull request May 8, 2018

Loop variables gone wrong, babel-preset-minify@0.4.0 regression #832

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Babel 7 #487

Upgrade to Babel 7 #487

boopathi commented Apr 3, 2017 •

edited

Loading

codecov bot commented Apr 3, 2017 •

edited

Loading

hzoo Apr 3, 2017

diervo commented Jun 22, 2017

hzoo commented Jun 23, 2017

diervo commented Jun 23, 2017 via email •

edited

Loading

diervo commented Jul 1, 2017

kelset commented Jul 4, 2017

boopathi commented Jul 10, 2017

vigneshshanmugam commented Sep 13, 2017

vigneshshanmugam Sep 13, 2017

remcohaszing commented Nov 7, 2017

vigneshshanmugam Feb 23, 2018

diervo commented Feb 24, 2018

hzoo commented Feb 24, 2018 •

edited

Loading

diervo commented Feb 24, 2018 •

edited

Loading

vigneshshanmugam commented Feb 24, 2018

boopathi commented Feb 28, 2018

vigneshshanmugam commented Feb 28, 2018

Upgrade to Babel 7 #487

Upgrade to Babel 7 #487

Conversation

boopathi commented Apr 3, 2017 • edited Loading

codecov bot commented Apr 3, 2017 • edited Loading

Codecov Report

hzoo Apr 3, 2017

Choose a reason for hiding this comment

diervo commented Jun 22, 2017

hzoo commented Jun 23, 2017

diervo commented Jun 23, 2017 via email • edited Loading

diervo commented Jul 1, 2017

kelset commented Jul 4, 2017

boopathi commented Jul 10, 2017

vigneshshanmugam commented Sep 13, 2017

vigneshshanmugam Sep 13, 2017

Choose a reason for hiding this comment

remcohaszing commented Nov 7, 2017

vigneshshanmugam Feb 23, 2018

Choose a reason for hiding this comment

diervo commented Feb 24, 2018

hzoo commented Feb 24, 2018 • edited Loading

diervo commented Feb 24, 2018 • edited Loading

vigneshshanmugam commented Feb 24, 2018

boopathi commented Feb 28, 2018

vigneshshanmugam commented Feb 28, 2018

boopathi commented Apr 3, 2017 •

edited

Loading

codecov bot commented Apr 3, 2017 •

edited

Loading

diervo commented Jun 23, 2017 via email •

edited

Loading

hzoo commented Feb 24, 2018 •

edited

Loading

diervo commented Feb 24, 2018 •

edited

Loading