Ensure binding exists #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
reviewed
Nov 2, 2016
| @@ -840,7 +840,7 @@ module.exports = ({ types: t, traverse }) => { | |||
| const binding = scope.getBinding(id.name); | |||
|
|
|||
| // Check if shadowed or is not referenced. | |||
| if (binding.path.node !== node || !binding.referenced) { | |||
| if (binding && (binding.path.node !== node || !binding.referenced)) { | |||
There was a problem hiding this comment.
this is for a function/class expression ... weird that there is no binding but an id exists.
There was a problem hiding this comment.
anyway this check is harmless, will merge it, can we just add a TODO: comment just above this line ... This function is affected when fixing this bug too afaik - #226
|
I was essentially re-writing this function to fix #226 ... Never mind .. I'll just keep this in mind .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this with one of our files. Don't have an easily reproducible testcase but maybe someone can think of something?