Skip to content

Commit

Permalink
Update dependencies (#55)
Browse files Browse the repository at this point in the history
* Update to latest Karma for testing
* Replace PhantomJS with jsdom for testing
* Downgrade Karma and jsdom when testing on Node <= 8
  • Loading branch information
MattiasBuelens authored Nov 30, 2020
1 parent 22679e2 commit 664432e
Show file tree
Hide file tree
Showing 4 changed files with 1,189 additions and 2,387 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,9 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- name: Downgrade Karma and jsdom for Node <= 8
if: matrix.node-version == '6' || matrix.node-version == '8'
run: |
npm uninstall karma karma-jasmine jsdom
npm install --save-dev karma@3 karma-jasmine@2 jsdom@11
- run: npm test
4 changes: 2 additions & 2 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ module.exports = function(config) {

plugins: [
'karma-jasmine',
'karma-phantomjs-launcher',
'karma-jsdom-launcher',
require('./lib')
],

Expand Down Expand Up @@ -85,7 +85,7 @@ module.exports = function(config) {

// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
browsers: ['PhantomJS'],
browsers: ['jsdom'],


// Continuous Integration mode
Expand Down
Loading

0 comments on commit 664432e

Please sign in to comment.