This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix "-1" array accesses in CommentsParser. #777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the fixes in babel/babel#6580 and
babel/babel#6581, accesses of the form
when
stack
can be an empty array are pretty bad for performance.In this case it also breaks the type safety, since the function
last<T>
is declared to only return values of typeT
, butoccasionally also returns
undefined
now, since thestack
parameterspassed to it never contain a property
"-1"
and neither do theObject.prototype
or theArray.prototype
.This is a non-breaking performance fix, which adds proper checking
to ensure that
last
is only invoked on non-empty arrays.