Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

chore: remove unnecessary return #751

Merged
merged 1 commit into from
Oct 9, 2017
Merged

chore: remove unnecessary return #751

merged 1 commit into from
Oct 9, 2017

Conversation

gebilaoxiong
Copy link
Contributor

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets no
License MIT

Andarist
Andarist approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only tests are still passing, I'm super glad about this change.

The previous pattern is always confusing, especially for newcomers and for me it's way better to just split return and the function call if its result is not used by the caller.

xtuc
xtuc approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, lgtm

@xtuc
Copy link
Member

xtuc commented Oct 9, 2017

I'll go ahead and merge this. Tests are green.

Thanks @gebilaoxiong!

@xtuc xtuc merged commit 6fc9af5 into babel:master Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Andarist Andarist Andarist approved these changes

@xtuc xtuc xtuc approved these changes

@danez danez danez approved these changes

Assignees
No one assigned
Labels
Tag: Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gebilaoxiong @xtuc @danez @Andarist @hzoo