This repository has been archived by the owner on May 19, 2018. It is now read-only.
Clean up uncatagorised decorators (1/2) #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Sep 24, 2017
| @@ -1 +0,0 @@ | |||
| @foo class Foo {} | |||
There was a problem hiding this comment.
It was almost the same as decorators/class-decorator/actual.js.
There was a problem hiding this comment.
I think we can keep both, since in decorators/class-decorator/actual.js the decorator is on a different line and thus have different locations.
There was a problem hiding this comment.
Alright, I added it back as decorators/class-decorator-new-line
There was a problem hiding this comment.
I am so glad that I have other people check my work. Sorry about that 😳.
|
Just a quick question, if I make more categorising PRs should they be bigger or smaller? For example, I am thinking of categorising the rest of uncategorisd/40-54. Should these be two PR or just one? |
|
This is a good size. |
|
Ok, Thanks. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved uncatagorised 34-40 into decorators. I did this to try to clean up the uncategorised directory a little bit.