-
-
Notifications
You must be signed in to change notification settings - Fork 258
Better error message for anonymous class declarations #509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 22 22
Lines 3524 3524
Branches 977 977
=======================================
Hits 3463 3463
Misses 22 22
Partials 39 39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it - dono if anyone else had opinions on the message itself
other suggestions: (probably bad since maybe shorter is better in this case) - most of the time you would have the codeframe anyway with Babel.
- a class name is required
- class names are required if not a default export
Cool - I also like "A class name is required". Thoughts/suggestions from
anyone else?
I'll probably leave as is if nobody else has an opinion if that's cool
…On Wed, May 3, 2017, 21:38 Henry Zhu ***@***.***> wrote:
***@***.**** approved this pull request.
Love it - dono if anyone else had opinions on the message itself
other suggestions: (probably bad since maybe shorter is better in this
case) - most of the time you would have the codeframe anyway with Babel.
- a class name is required
- class names are required if not a default export
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#509 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAq_LgFGBmB7W9wNbo019pB8vdnbGNEtks5r2VYugaJpZM4NQK3T>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like "A class name is required" as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎 Nice work
65ba7e4
to
e2014e2
Compare
Awesome, thanks guys! Updated to |
Given code like:
or
Instead of
Unexpected token (1:6)
, getClass name required (1:6)