This repository has been archived by the owner on May 19, 2018. It is now read-only.
Add support for declare export + fixes #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 98.2% 98.24% +0.03%
==========================================
Files 20 20
Lines 3462 3530 +68
Branches 935 972 +37
==========================================
+ Hits 3400 3468 +68
Misses 23 23
Partials 39 39
Continue to review full report at Codecov.
|
danez
changed the title
danez
changed the title
loganfsmyth
reviewed
Apr 9, 2017
src/plugins/flow.js
Outdated
| ["const"]: "declare export var", | ||
| ["let"]: "declare export var", | ||
| ["type"]: "export type", | ||
| ["interface"]: "export interface", |
There was a problem hiding this comment.
Hmm, well...I change it :D
existentialism
approved these changes
Apr 11, 2017
Add check for multiple module.export declarations
Refactor parsing object properties to share more code and add support for getters and setters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for
declare export. I tried to follow the flow parser as close as possible.I also found some related problems and fixed them.
kind