fix flow-comments - class type paramters and implements #9897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tanhauhau
commented
Apr 24, 2019
tanhauhau
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #5626 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
area: comments
area: flow
PR: Bug Fix 🐛
| .map(impl => generateComment(impl).replace(/^:: /, "")) | ||
| .join(", "), | ||
| ); | ||
| delete node["implements"]; |
There was a problem hiding this comment.
Doesn't impls.remove() work? It's better not to mutate the ast directly, since path methods sometimes do some clean up when mutating nodes.
There was a problem hiding this comment.
impls is an array, there's no .remove()
should I clone the node, modify and path.replaceWith(...) with the clone?
There was a problem hiding this comment.
Oh you can impls.forEach(p => p.remove())
There was a problem hiding this comment.
I remembered I tried it before, i ended up with class Foo implements {
nicolo-ribaudo
approved these changes
Apr 26, 2019
existentialism
approved these changes
Apr 26, 2019
This was referenced Aug 17, 2019
This was referenced Sep 17, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.