Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md using the "Trigger GitHub release" action #9561

Merged

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

We haven't been very good at keeping CHANGELOG.md updated (2 days ago I added the changelog for versions 7.2.2-7.2.3 21eb083, and the previus commit was for versions 7.1.3-7.2.1 b60adce).

This PR updates the action we use to generate the GitHub release so that it also updates CHANGELOG.md (commit author: @babel-bot 😄). Btw, I'm trying to understand how I can test this action which chages the git tree and makes requests to the GH api, but I'm not doing it in this PR since it will take a lot of time to properly set up.

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories area: publishing process labels Feb 22, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10223/

Copy link
Collaborator

@babel-bot babel-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beep Boop LGTM

@babel babel deleted a comment from babel-bot Feb 22, 2019
@xtuc xtuc requested a review from babel-bot February 22, 2019 10:24
@danez danez changed the title Update CHAMGELOG.md using the "Trigger GitHub release" action Update CHANGELOG.md using the "Trigger GitHub release" action Feb 22, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 4540f26 into babel:master Feb 25, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the gh-action-update-changelog-md branch February 25, 2019 18:18
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: publishing process outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants