Exclude generate @babel/types files from coverage report #9469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
area: tests
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10008/ |
|
About the helpers I am not sure. Most of them I guess are used somewhere in this repo, at least I always assumed. But testing them would be good and probably not too hard to do. |
|
Well, if the coverage report says 0% it is because we aren't using them anywhere. |
|
Or the location where it is used is also not tested :P |
existentialism
approved these changes
Feb 8, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think that we should include these files in the coverage report, since testing them is not realistic anyway?
https://github.com/babel/babel/blob/master/packages/babel-types/src/validators/generated/index.js
Also, there are a lots of untested unused helpers in babel/types (e.g. https://codecov.io/gh/babel/babel/src/master/packages/babel-types/src/validators/isSpecifierDefault.js): we should check them one by one and decide if we want to deprecate them and remove in v8 or make
good first issueissues to test them.