Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strips flow directive fully #9197

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Strips flow directive fully #9197

merged 1 commit into from
Dec 17, 2018

Conversation

tanhauhau
Copy link
Member

Q                       A
Fixed Issues? Fixes #9192
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

[transform-flow-strip-types] Strip out flow directives for various flow mode.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9624/

nicolo-ribaudo
nicolo-ribaudo approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicolo-ribaudo nicolo-ribaudo merged commit 52fb884 into babel:master Dec 17, 2018
@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: flow labels Dec 17, 2018
@tanhauhau tanhauhau deleted the tanhauhau/strip-flow-comment branch February 19, 2019 10:24
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IvanGoncharov IvanGoncharov IvanGoncharov approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[transform-flow-strip-types] Strips flow directive only partially
5 participants
@tanhauhau @babel-bot @nicolo-ribaudo @IvanGoncharov @existentialism