Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow placeholders in JSXElements when parsing templates #7583

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Allow placeholders in JSXElements when parsing templates #7583

merged 1 commit into from
Mar 23, 2018

Conversation

Andarist
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? x
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

@Andarist Andarist added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: template labels Mar 16, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Mar 16, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7281/

@Andarist Andarist merged commit f98dff9 into babel:master Mar 23, 2018
@Andarist Andarist deleted the templates/jsx branch March 23, 2018 08:27
@xtuc
Copy link
Member

xtuc commented Mar 23, 2018

Ah sorry, could we update the doc? that's an interesting feature.

@Andarist
Copy link
Member Author

@xtuc what kind of info would u like to have included for this in the docs? they do not describe what kind of nodes can be passed to templating functions, while this is a "new feature" it could also be seen as a fix

@xtuc
Copy link
Member

xtuc commented Mar 23, 2018

Yes, you are right, it's a pretty obvious feature. I was just thinking about adding an example but i'm fine either ways.

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danez danez danez approved these changes

@xtuc xtuc xtuc approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: template PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andarist @babel-bot @xtuc @danez