Allow sourceType:unambiguous as a way to tell Babylon to guess the type. #6789
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5763/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5740/ |
|
Should add a readme change for the new option? @bmeck @Kovensky |
hzoo
added
the
PR: New Feature 🚀
| (!child.exportKind || child.exportKind === "value")) || | ||
| child.type === "ExportDefaultDeclaration", | ||
| ); | ||
| } |
There was a problem hiding this comment.
👆 Neat! (I might borrow this helper)
There was a problem hiding this comment.
Yeah this is basically to stay in line with babel/babylon#771 since Flowtype just indiscriminately allows mixing ES6 import/export and CommonJS and it seems fine to allow type import/export inside sourceType:script files.
There was a problem hiding this comment.
@loganfsmyth Who made your avatar!?
There was a problem hiding this comment.
Got it from Matt Cummings. His commissions are open again: https://twitter.com/EiffelArt/status/928017289416495105
| } catch (scriptError) {} | ||
|
|
||
| throw moduleError; | ||
| } |
There was a problem hiding this comment.
👆 This aligns with my approach as well.
| ) { | ||
| throw new Error( | ||
| `.${key} must be "module", "script", "unambiguous", or undefined`, | ||
| ); |
There was a problem hiding this comment.
The alphabetical listing of these sourceTypes in the error text is satisfying!
| @@ -91,3 +111,16 @@ function getParserClass( | |||
| } | |||
| return cls; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Could hasModuleSyntax be simplified?
Is there ever a child.type of ImportDeclaration and friends
that don't have the accompanying importKind and exportKind values?
There was a problem hiding this comment.
I believe when the flow parsing isn't enabled, they aren't set.
lock
bot
added
the
outdated
Repost of babel/babylon#449. Also added tweaks to option parsing so that the option passes through properly.