Split up babel-core's File class and add Flowtype annotations #6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5142/ |
loganfsmyth
force-pushed
the
file-simplification
branch
from
47bf597
to
5198972
Compare
hzoo
added
the
PR: Internal 🏠
existentialism
approved these changes
Oct 2, 2017
hzoo
reviewed
Oct 2, 2017
| @@ -1,6 +1,5 @@ | |||
| export default class Hub { | |||
| constructor(file, options) { | |||
There was a problem hiding this comment.
is it even worth having this file if it's just a file? or just move to src/index.js as export class Hub { }
There was a problem hiding this comment.
Yeah we can revisit, I just didn't want to change any of the actual transform infrastructure.
jridgewell
approved these changes
Oct 2, 2017
loganfsmyth
force-pushed
the
file-simplification
branch
from
5198972
to
f02e684
Compare
jamiebuilds
reviewed
Oct 17, 2017
| @@ -1,39 +1,42 @@ | |||
| export File from "./transformation/file"; | |||
There was a problem hiding this comment.
Can we continue to export File? I need it in a number of places to create nice error messages
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.FYI, may be easiest to review by commit. Mostly refactoring. I've removed the parts of the
Fileclass that weren't part of the user-facing API and moved then to be their own files.Actual features in here:
browserfiles for the 2transformFile*files that actually rely onfsso Webpack will complain less.babel-corenow exceptbuild-external-helpers.babel-template