Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite parameter transform and drop _blockHoist reliance #6051

Merged
merged 5 commits into from
Aug 4, 2017
Merged

Rewrite parameter transform and drop _blockHoist reliance #6051

merged 5 commits into from
Aug 4, 2017

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Aug 4, 2017

Rebases and closes #5709. Also applies loose mode change from #5943.

@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 4, 2017
@mention-bot
Copy link

@existentialism, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @jridgewell and @vhf to be potential reviewers.

@hzoo hzoo added this to the Babel 7 milestone Aug 4, 2017
@danez
Copy link
Member

danez commented Aug 4, 2017

I didn't looked at every line, but overall it looks good. The testcase changes all make sense.

@hzoo hzoo merged commit 47a9ba3 into 7.0 Aug 4, 2017
@hzoo
Copy link
Member

hzoo commented Aug 4, 2017

Thanks @loganfsmyth for this (huge change to get rid of those _ props and @existentialism for rebasing!

@danez danez deleted the 5709-2 branch August 5, 2017 09:09
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants