Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in CONTRIBUTING.md #4989

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Dec 11, 2016

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets none
License MIT
Doc PR yes
Dependency Changes no

@xtuc xtuc added bug PR: Docs 📝 A type of pull request used for our changelog categories labels Dec 11, 2016
@xtuc
Copy link
Member

xtuc commented Dec 11, 2016

I think you should add an internals section to the CONTRIBUTING.md with the following links:

@hiroppy hiroppy force-pushed the feature/fix-links-in-contributing branch from c7df651 to 64e8a44 Compare December 12, 2016 05:13
@hiroppy
Copy link
Member Author

hiroppy commented Dec 12, 2016

@xtuc Updated.

@codecov-io
Copy link

codecov-io commented Dec 12, 2016

Current coverage is 89.10% (diff: 100%)

No coverage report found for master at 0ed97ce.

Powered by Codecov. Last update 0ed97ce...c7df651

@xtuc
Copy link
Member

xtuc commented Dec 12, 2016

LGTM 👍

/cc @hzoo @existentialism ok for you?

@hzoo hzoo merged commit 68148b8 into babel:master Dec 12, 2016
@hzoo
Copy link
Member

hzoo commented Dec 12, 2016

Cool 👍

@hiroppy hiroppy deleted the feature/fix-links-in-contributing branch December 13, 2016 08:53
Jessidhia pushed a commit to Jessidhia/babel that referenced this pull request Dec 16, 2016
* master: (89 commits)
  fix sizing [skip ci]
  typo [skip ci]
  changelog for v6.20.1 to v6.20.3 [skip ci]
  mention repl/link [skip ci]
  add semver label [skip ci]
  Fix links in CONTRIBUTING.md [skip ci] (babel#4989)
  make installing runtime/transform-runtime clearer [skip ci] (babel#4991)
  Add example to es2015-unicode-regex [skip ci] (babel#4983)
  v6.20.3
  Calculate the correct arity for async functions with destructuring - fixes babel#4977 (babel#4978)
  v6.20.2
  fix object spread (babel#4976)
  fix clean lib
  update readme [skip ci]
  v6.20.1
  Fix nested object spread (babel#4974)
  v6.20.0
  v6.20.0 changelog [skip ci] (babel#4971)
  Raise limit on code size before compacting (babel#4965)
  Use regenerator-transform to implement babel-plugin-transform-regenerator (babel#4881)
  ...
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants