Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: invalid codegen for non decimal numeric literals in MemberExpression #3379

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Fix: invalid codegen for non decimal numeric literals in MemberExpression #3379

merged 1 commit into from
Feb 29, 2016
+16 −1

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Feb 29, 2016

Similar to #3170

Bug: (0xFFFF).toString() ---> 0xFFFF..toString()

cc @tolmasky

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Feb 29, 2016
@hzoo hzoo added this to the 6.5.x milestone Feb 29, 2016
@hzoo hzoo force-pushed the memexp-numliteral branch from 7e75b3c to 35ed18f Compare February 29, 2016 01:35
@codecov-io
Copy link

Current coverage is 85.24%

Merging #3379 into master will decrease coverage by -0.19% as of 82eca87

@@            master   #3379   diff @@
======================================
  Files          216     216       
  Stmts        15855   15856     +1
  Branches      3405    3405       
  Methods          0       0       
======================================
- Hit          13545   13517    -28
- Partial        680     709    +29
  Missed        1630    1630

Review entire Coverage Diff as of 82eca87

Powered by Codecov. Updated on successful CI builds.

@loganfsmyth
Copy link
Member

Looks good to me.

@hzoo hzoo changed the title Fix invalid codegen for non decimal numeric literals in MemberExpression Fix: invalid codegen for non decimal numeric literals in MemberExpression Feb 29, 2016
hzoo added a commit that referenced this pull request Feb 29, 2016
@hzoo
Merge pull request #3379 from babel/memexp-numliteral
66ea534 
Fix: invalid codegen for non decimal numeric literals in MemberExpression
@hzoo hzoo merged commit 66ea534 into master Feb 29, 2016
@hzoo hzoo deleted the memexp-numliteral branch February 29, 2016 16:40
@babel-bot babel-bot mentioned this pull request Sep 7, 2016
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
Minor
Development

Successfully merging this pull request may close these issues.
3 participants
@hzoo @codecov-io @loganfsmyth