Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check BindExpression callee for reference - fixes T6984 #3334

Merged
merged 1 commit into from
Feb 11, 2016
Merged

Check BindExpression callee for reference - fixes T6984 #3334

merged 1 commit into from
Feb 11, 2016

Conversation

loganfsmyth
Copy link
Member

We weren't properly checking callee on BindExpression.

@codecov-io
Copy link

Current coverage is 85.22%

Merging #3334 into master will decrease coverage by -0.24% as of b13be64

@@            master   #3334   diff @@
======================================
  Files          215     215       
  Stmts        15768   15769     +1
  Branches      3385    3386     +1
  Methods          0       0       
======================================
- Hit          13476   13439    -37
- Partial        671     707    +36
- Missed        1621    1623     +2

Review entire Coverage Diff as of b13be64

Powered by Codecov. Updated on successful CI builds.

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Feb 7, 2016
@hzoo
Copy link
Member

hzoo commented Feb 7, 2016

https://phabricator.babeljs.io/T6984. Should we add an exec.js test for this one?

@loganfsmyth
Copy link
Member Author

@hzoo Your call, I don't feel strongly one way or the other.

@hzoo
Copy link
Member

hzoo commented Feb 7, 2016

I think since it was an issue found after running it we could do an exec.js test

hzoo
hzoo reviewed Feb 9, 2016
View reviewed changes
packages/babel-plugin-transform-function-bind/test/fixtures/regression/T6984/options.json
@@ -0,0 +1,3 @@
{
"plugins": ["transform-function-bind", "transform-es2015-classes"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but do we want to use external helpers to make it shorter?

@hzoo hzoo added this to the 6.5.x milestone Feb 9, 2016
loganfsmyth added a commit that referenced this pull request Feb 11, 2016
@loganfsmyth
Merge pull request #3334 from loganfsmyth/bind-callee-ref
b53864c 
Check BindExpression callee for reference - fixes T6984
@loganfsmyth loganfsmyth merged commit b53864c into babel:master Feb 11, 2016
@loganfsmyth loganfsmyth deleted the bind-callee-ref branch February 11, 2016 05:42
@babel-bot babel-bot mentioned this pull request Sep 7, 2016
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
Minor
Development

Successfully merging this pull request may close these issues.
3 participants
@loganfsmyth @codecov-io @hzoo