Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parser] enable dynamic import by default #10843

Merged
merged 2 commits into from
Jan 10, 2020
Merged

[parser] enable dynamic import by default #10843

merged 2 commits into from
Jan 10, 2020

Conversation

AbdulAli19
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10824
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Tests Added + Pass? No
Documentation PR Link
Any Dependency Changes? No
License MIT

@AbdulAli19
Copy link
Contributor Author

AbdulAli19 commented Dec 9, 2019 •
edited
Loading

couldn't get tests to pass locally so i figure i'm missing something. thought i'd create this pr anyway to get feedback/help on what that might be.

edit: the tests that are failing in ci are different than what i was seeing locally, going to see to if i can fix the ones that are failing in ci

@AbdulAli19 AbdulAli19 force-pushed the dynamic-import-default branch from 26b890c to a41b2e2 Compare December 9, 2019 05:16
@nicolo-ribaudo nicolo-ribaudo added pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories labels Dec 9, 2019
@nicolo-ribaudo nicolo-ribaudo added this to the v7.8.0 milestone Dec 9, 2019
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 9, 2019 •
edited
Loading

The babel-preset-env/ failing test is not caused by this PR.
Also, the /es2020/dynamic-import/no-plugin/input.js and experimental/_no plugin/dynamic import/* files can be deleted.

@AbdulAli19
Copy link
Contributor Author

Also, the /es2020/dynamic-import/no-plugin/input.js file can be deleted.

can i also get rid of /experimental/_no-plugin/dynamic-import/input.js?

@AbdulAli19 AbdulAli19 force-pushed the dynamic-import-default branch from a41b2e2 to baceca9 Compare December 9, 2019 09:19
@AbdulAli19
Copy link
Contributor Author

the babel-preset-env/ test is the only failing test now. thanks for the help, @nicolo-ribaudo!

@nicolo-ribaudo
Copy link
Member

Rebasing on master should make the tests pass

@AbdulAli19 AbdulAli19 force-pushed the dynamic-import-default branch from baceca9 to b2fd90b Compare December 10, 2019 05:26
existentialism
existentialism approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @AbdulAli19 nice work!

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Dec 20, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 5b907e9 into babel:master Jan 10, 2020
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 5, 2020
Open
This was referenced Feb 22, 2020
Open
Open
Merged
This was referenced Mar 7, 2020
Merged
Merged
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 14, 2020
Merged
This was referenced Mar 17, 2020
Open
Merged
Merged
Open
Open
Closed
Open
Open
This was referenced Mar 24, 2020
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 1, 2020
Open
Open
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Dynamic Import
Projects
None yet
Milestone
v7.8.0
Development

Successfully merging this pull request may close these issues.

Enable dynamic import by default in @babel/parser
4 participants
@AbdulAli19 @nicolo-ribaudo @existentialism @kaicataldo